ashoke-cube commented on code in PR #16095:
URL: https://github.com/apache/kafka/pull/16095#discussion_r1644974636
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -307,7 +307,7 @@ void doShutdown() {
+ " as the connector has been scheduled
for shutdown"),
null);
}
- if (state == State.STARTED)
+ if (state == State.STARTED || state == State.FAILED)
connector.stop();
Review Comment:
Done. Please do take a look.
There are state transitions possible from INIT-> STOPPED/PAUSED. We don't
call `stop()` in suspend, if the state is not STARTED. There shouldn't be any
resource allocation in `initialize()` of a connector for this to be an issue,
but wanted to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
