[
https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856093#comment-17856093
]
Chia-Ping Tsai commented on KAFKA-16959:
----------------------------------------
[~tailm.asf] nice point. KIP-543 says:
{quote}
Alter an entity's config by adding/updating/removing config entries. The given
entity name may either be a specific entity (via --entity-name) or, if
supported, the default config for all entities (via --entity-default).
{quote}
Personally, it does not explicitly declare that we can input "both" kind of
entity. Also, current implementation [0] seems to send request for the "head"
of entity only.
BUT, I feel the point from [~tailm.asf] is better than my previous intent.
Instead of throwing exception, making it work with both entities is more
valuable.
[~m1a2st] [~tailm.asf] WDYT?
[0]
https://github.com/apache/kafka/blob/e2060204fead9aa03f611b76c543b6824f8eb26b/core/src/main/scala/kafka/admin/ConfigCommand.scala#L401
> ConfigCommand should not allow to define both `entity-default` and
> `entity-name`
> --------------------------------------------------------------------------------
>
> Key: KAFKA-16959
> URL: https://issues.apache.org/jira/browse/KAFKA-16959
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: 黃竣陽
> Priority: Minor
>
> When users input both `entity-default` and `entity-name`, only `entity-name`
> will get evaluated. It seems to me that is error-prone. We should throw
> exception directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
