[
https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856096#comment-17856096
]
黃竣陽 edited comment on KAFKA-16959 at 6/19/24 1:46 AM:
------------------------------------------------------
In this sentence
??Alter an entity's config by adding/updating/removing config entries. The
given entity name may either be a specific entity (via --entity-name) or, if
supported, the default config for all entities (via --entity-default).??
I think that we should focus on "either ... or ...", It means we should choose
one kind of entity.
If we can use two kind entities, we need to check adding/updating/removing
config belongs to which Update Mode. Personally, It will make code complex.
[~chia7712] [~tailm.asf] WDYT?
was (Author: JIRAUSER305187):
In this sentence
> Alter an entity's config by adding/updating/removing config entries. The
> given entity name may either be a specific entity (via --entity-name) or, if
> supported, the default config for all entities (via --entity-default).
I think that we should focus on "either ... or ...", It means we should choose
one kind of entity.
If we can use two kind entities, we need to check adding/updating/removing
config belongs to which Update Mode. Personally, It will make code complex.
[~chia7712] [~tailm.asf] WDYT?
> ConfigCommand should not allow to define both `entity-default` and
> `entity-name`
> --------------------------------------------------------------------------------
>
> Key: KAFKA-16959
> URL: https://issues.apache.org/jira/browse/KAFKA-16959
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: 黃竣陽
> Priority: Minor
>
> When users input both `entity-default` and `entity-name`, only `entity-name`
> will get evaluated. It seems to me that is error-prone. We should throw
> exception directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
