frankvicky commented on code in PR #16396:
URL: https://github.com/apache/kafka/pull/16396#discussion_r1649964164
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java:
##########
@@ -161,14 +163,14 @@ private void overwriteInternalTopicManagerWithMock() {
partitionAssignor.setInternalTopicManager(mockInternalTopicManager);
}
- @Before
public void setUp() {
- adminClient =
createMockAdminClientForAssignor(EMPTY_CHANGELOG_END_OFFSETS);
+ adminClient =
createMockAdminClientForAssignor(EMPTY_CHANGELOG_END_OFFSETS, true);
}
@Test
public void
shouldReturnAllActiveTasksToPreviousOwnerRegardlessOfBalanceAndTriggerRebalanceIfEndOffsetFetchFailsAndHighAvailabilityEnabled()
{
+ setUp();
Review Comment:
Indeed, this is the only one test case which call `setup` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
