chia7712 commented on code in PR #16413:
URL: https://github.com/apache/kafka/pull/16413#discussion_r1650083987


##########
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##########
@@ -372,12 +372,12 @@ void onRequestSent(long correlationId, long timeMs) {
         @Override
         public String toString() {
             return String.format(
-                "ConnectionState(node=%s, state=%s, lastSendTimeMs=%d, 
lastFailTimeMs=%d, inFlightCorrelationId=%d)",
+                "ConnectionState(node=%s, state=%s, lastSendTimeMs=%d, 
lastFailTimeMs=%d, inFlightCorrelationId=%s)",
                 node,
                 state,
                 lastSendTimeMs,
                 lastFailTimeMs,
-                inFlightCorrelationId
+                inFlightCorrelationId.isPresent() ? 
inFlightCorrelationId.getAsLong() : null

Review Comment:
   how about using `undefined` to replace "null"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to