adixitconfluent commented on PR #16414: URL: https://github.com/apache/kafka/pull/16414#issuecomment-2185094033
> Thanks for the PR. Looks good overall, with just a request to comment at least one of the unit tests a bit more comprehensively to make it easier to see what is intended. If the behaviour ever changes subtly, we might have to revisit them and making them a little easier to read would be helpful. Thanks for the review @AndrewJSchofield , I have added a few comments to most of these tests to explain the intention. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
