Re: [PR] KAFKA-15265: Remote fetch throttle metrics [kafka]

[via GitHub]

abhijeetk88 commented on PR #16087:
URL: https://github.com/apache/kafka/pull/16087#issuecomment-2185630174

   > @abhijeetk88
   > 
   > Thanks for the patch! Verified that the metric is emitted via Jconsole. 
The metric objectName is set to `kafka.server:type=RemoteLogManager`, should we 
rename it to `kafka.log.remote:type=RemoteLogManager` instead?
   > 
   > Also, can you add description to each of the metric?
   > 
   > <img alt="Screenshot 2024-06-12 at 10 43 00 PM" width="1140" 
src="https://private-user-images.githubusercontent.com/11411249/339067376-7131d82e-0735-44b4-8120-2b8f7956f682.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkyMDY0MzksIm5iZiI6MTcxOTIwNjEzOSwicGF0aCI6Ii8xMTQxMTI0OS8zMzkwNjczNzYtNzEzMWQ4MmUtMDczNS00NGI0LTgxMjAtMmI4Zjc5NTZmNjgyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI0VDA1MTUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1YmNjNDU5OTI2ZDA5MWQzNmFlMGUzOTIzZjJmOGI0MGE3ZjI2NGQwNTI3ZTU2N2FiMTRlMmI1N2QxMDc0NDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TnaOqEOfEmB3cI5IRQ7AOD8Ge3Orjnf-otD26dWfuzk";>
   
   I am facing a problem here. When creating a SensorAccess, it needs 
_org.apache.kafka.common.metrics.Metrics_, but with this the prefix becomes 
kafka.server and cannot be changed. We instead need to use _KafkaMetricsGroup_ 
but there is no way to create SensorAccess with it.
   
   @kamalcph @showuon are you aware of a workaround?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org