chia7712 commented on code in PR #16420:
URL: https://github.com/apache/kafka/pull/16420#discussion_r1650736148
##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -258,11 +259,22 @@ private static ApiVersionsResponseData
createApiVersionsResponseData(
final long finalizedFeaturesEpoch,
final boolean zkMigrationEnabled
) {
+ Features<SupportedVersionRange> backwardsCompatibleFeatures =
Features.supportedFeatures(latestSupportedFeatures.features().entrySet()
+ .stream().filter(entry -> {
+ SupportedVersionRange supportedVersionRange = entry.getValue();
+ return supportedVersionRange.min() != 0;
Review Comment:
not sure whether I fail to catch your description.
> so for now we will change 0 to 1 in the response in order to be backwards
compatible.
the code looks like it gets rid of "0" instead of changing to from 0 to 1.
##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -258,11 +259,22 @@ private static ApiVersionsResponseData
createApiVersionsResponseData(
final long finalizedFeaturesEpoch,
final boolean zkMigrationEnabled
) {
+ Features<SupportedVersionRange> backwardsCompatibleFeatures =
Features.supportedFeatures(latestSupportedFeatures.features().entrySet()
+ .stream().filter(entry -> {
+ SupportedVersionRange supportedVersionRange = entry.getValue();
+ return supportedVersionRange.min() != 0;
Review Comment:
For another, does this PR mean `Admin#describeFeatures` can't see the
feature "group.version" from the broker running in 3.8.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
