adixitconfluent commented on code in PR #16431:
URL: https://github.com/apache/kafka/pull/16431#discussion_r1650931188
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {
any(), any(), any(ReplicaQuota.class), any());
}
+ @Test
+ public void testCloseSharePartitionManager() throws Exception {
+ SharePartitionManager sharePartitionManager =
SharePartitionManagerBuilder.builder()
+ .withShareGroupPersister(mock(Persister.class)).build();
Review Comment:
you're right, we don't need to mock it. I have removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
