[ 
https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai reassigned KAFKA-17027:
--------------------------------------

    Assignee: PoAn Yang

> Inconsistent casing in Selector metrics tags
> --------------------------------------------
>
>                 Key: KAFKA-17027
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17027
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core, metrics
>            Reporter: Mickael Maison
>            Assignee: PoAn Yang
>            Priority: Major
>
> When creating metric tags for a Selector instance, we use "broker-id" in 
> ControllerChannelManager, BrokerBlockingSender and ReplicaFetcherBlockingSend 
> but we use "BrokerId" in NodeToControllerChannelManagerImpl.
> Not only these casing are inconsistent for metrics tags for the same 
> component (Selector) but it looks like neither match the casing the use for 
> other broker metrics!
> We seem to always use lower camel case for tags for broker metrics. For 
> example, we have "networkProcessor", "clientId", "delayedOperation", 
> "clientSoftwareName", "clientSoftwareVersion" as tags on other metrics.
> Fixing this will require a KIP.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to