frankvicky commented on code in PR #16455: URL: https://github.com/apache/kafka/pull/16455#discussion_r1657068184
########## core/src/main/scala/kafka/server/KafkaApis.scala: ########## @@ -936,12 +936,10 @@ class KafkaApis(val requestChannel: RequestChannel, } erroneous.foreach { case (tp, data) => partitions.put(tp, data) } - var unconvertedFetchResponse: FetchResponse = null - - def createResponse(throttleTimeMs: Int): FetchResponse = { + def createResponse(throttleTimeMs: Int, fetchResponse: FetchResponse): FetchResponse = { Review Comment: I will try to refactor it 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org