adixitconfluent commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663802402


##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -1246,26 +1250,40 @@ public void testCloseSharePartitionManager() throws 
Exception {
     @Test
     public void testReleaseAcquiredRecordsSuccess() {
         String groupId = "grp";
-        String memberId = Uuid.randomUuid().toString();
+        Uuid memberId = Uuid.randomUuid();

Review Comment:
   Any particular reason toString method is removed here and then used at 
multiple places within the test wherever memberId is being used? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to