dajac commented on code in PR #16458: URL: https://github.com/apache/kafka/pull/16458#discussion_r1663920778
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ########## @@ -297,61 +333,92 @@ public class GroupCoordinatorConfig { * Also, when a topic is deleted via the delete-topic request, upon propagated metadata update any group's * committed offsets for that topic will also be deleted without extra retention period. */ - public final long offsetsRetentionMs; + public long offsetsRetentionMs() { + return config.getInt(GroupCoordinatorConfig.OFFSETS_RETENTION_MINUTES_CONFIG) * 60L * 1000L; + } /** * Offset commit will be delayed until all replicas for the offsets topic receive the commit * or this timeout is reached */ - public final int offsetCommitTimeoutMs; + public int offsetCommitTimeoutMs() { + return config.getInt(GroupCoordinatorConfig.OFFSET_COMMIT_TIMEOUT_MS_CONFIG); + } /** * The config indicating whether group protocol upgrade/downgrade are allowed. */ - public final ConsumerGroupMigrationPolicy consumerGroupMigrationPolicy; + public ConsumerGroupMigrationPolicy consumerGroupMigrationPolicy() { + return ConsumerGroupMigrationPolicy.parse( + config.getString(GroupCoordinatorConfig.CONSUMER_GROUP_MIGRATION_POLICY_CONFIG)); + } Review Comment: Indeed. I was thinking about the case where the validation has a bug or is not good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org