C0urante commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1664298524
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -106,6 +108,17 @@ public void stop() {
Utils.closeQuietly(targetAdminClient, "target admin client");
}
+ @Override
+ public Config validate(Map<String, String> connectorConfigs) {
+ List<ConfigValue> configValues =
super.validate(connectorConfigs).configValues();
+ MirrorCheckpointConfig.validate(connectorConfigs).forEach((config,
errorMsg) ->
+ configValues.stream()
+ .filter(conf -> conf.name().equals(config))
Review Comment:
I still agree with @mimaison that we shouldn't have this property in the
`MirrorConnectorConfig` class, since then it'll be included as a "common
config" for all connectors in our generated docs
[here](https://kafka.apache.org/37/documentation.html#mirrormakercommonconfigs)
instead of in the `MirrorSourceConnector`-specific docs
[here](https://kafka.apache.org/37/documentation.html#mirrormakersourceconfigs).
Can we just add a new `ConfigValue` for the property in
`MirrorCheckpointConnector::validate` if we find a validation error with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
