soarez commented on PR #16287: URL: https://github.com/apache/kafka/pull/16287#issuecomment-2206328635
@mimaison I suspect some of the difficulty comes from the reason for this PR: the current script is difficult to reason about. If you think it would help with the review, I can look into adding unit tests for some of new modules here. The downside is that the diff will be even larger. I'm also not sure how we'd plug them into CI, but you could run them locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org