chirag-wadhwa5 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1665592992
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -4004,6 +4488,99 @@ class KafkaApis(val requestChannel: RequestChannel,
CompletableFuture.completedFuture[Unit](())
}
+
+ def getAcknowledgeBatchesFromShareFetchRequest(
+ shareFetchRequest :
ShareFetchRequest,
+ topicNames : util.Map[Uuid,
String],
+ erroneous :
mutable.Map[TopicIdPartition, ShareAcknowledgeResponseData.PartitionData],
+ ) :
mutable.Map[TopicIdPartition, util.List[ShareAcknowledgementBatch]] = {
+
+ val acknowledgeBatchesMap = mutable.Map[TopicIdPartition,
util.List[ShareAcknowledgementBatch]]()
+ shareFetchRequest.data().topics().forEach ( topic => {
+
+ if(!topicNames.asScala.contains(topic.topicId)) {
+ topic.partitions.forEach((partition:
ShareFetchRequestData.FetchPartition) => {
+ val topicIdPartition = new TopicIdPartition(
+ topic.topicId,
+ new TopicPartition(null, partition.partitionIndex))
+ erroneous +=
+ topicIdPartition ->
ShareAcknowledgeResponse.partitionResponse(topicIdPartition,
Errors.UNKNOWN_TOPIC_ID)
+ })
+ }
+ else {
+ topic.partitions().forEach ( partition => {
+ val topicIdPartition = new TopicIdPartition(
+ topic.topicId(),
+ new TopicPartition(topicNames.get(topic.topicId()),
partition.partitionIndex())
+ )
+ var exceptionThrown = false
+ val acknowledgeBatches = new
util.ArrayList[ShareAcknowledgementBatch]()
+ breakable{
+ partition.acknowledgementBatches().forEach( batch => {
+ try {
+ acknowledgeBatches.add(new ShareAcknowledgementBatch(
+ batch.firstOffset(),
+ batch.lastOffset(),
+ batch.acknowledgeTypes()
+ ))
+ } catch {
+ case e : IllegalArgumentException =>
+ exceptionThrown = true
+ erroneous += topicIdPartition ->
ShareAcknowledgeResponse.partitionResponse(topicIdPartition,
Errors.forException(e))
+ break
+ }
+ })
+ }
+ if(!exceptionThrown && acknowledgeBatches.size() > 0) {
+ acknowledgeBatchesMap += topicIdPartition -> acknowledgeBatches
+ }
+ })
+ }
+ })
+ acknowledgeBatchesMap
+ }
+
+ def validateAcknowledgementBatches(
+ acknowledgementDataFromRequest :
mutable.Map[TopicIdPartition, util.List[ShareAcknowledgementBatch]],
+ erroneous :
mutable.Map[TopicIdPartition, ShareAcknowledgeResponseData.PartitionData]
+ ) : mutable.Set[TopicIdPartition] = {
+ val erroneousTopicIdPartitions: mutable.Set[TopicIdPartition] =
mutable.Set.empty[TopicIdPartition]
+ acknowledgementDataFromRequest.foreach{ case (tp : TopicIdPartition,
acknowledgeBatches : util.List[ShareAcknowledgementBatch]) =>
+ var prevEndOffset = -1L
+ breakable {
+ acknowledgeBatches.forEach(batch => {
+ if (batch.firstOffset > batch.lastOffset) {
Review Comment:
Thanks for the review ! Yes we can but I did that for better readability,
without affecting the execution at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
