FrankYang0529 commented on code in PR #16449:
URL: https://github.com/apache/kafka/pull/16449#discussion_r1665795593
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -2121,6 +2136,8 @@ private void
assertStaleMemberLeavesGroupAndClearsAssignment(MembershipManagerIm
assertTrue(membershipManager.currentAssignment().isNone());
assertTrue(membershipManager.topicsAwaitingReconciliation().isEmpty());
assertEquals(LEAVE_GROUP_MEMBER_EPOCH,
membershipManager.memberEpoch());
+ membershipManager.leaveGroup();
+ verify(subscriptionState).unsubscribe();
Review Comment:
Thank you for the detailed explanation. Sorry that I misunderstood your
previous comment. I need to read KIP-848 again to catch up more detailed logic
here. Could you also check that whether other places use correct
`verify(subscriptionState).unsubscribe();` statement? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
