lianetm commented on code in PR #16449: URL: https://github.com/apache/kafka/pull/16449#discussion_r1667043062
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java: ########## @@ -69,7 +70,8 @@ public void setup() { processor = new ApplicationEventProcessor( new LogContext(), requestManagers, - metadata + metadata, + mock(SubscriptionState.class) Review Comment: Could we add a test for the UnsubscribeEvent processing to cover what we expect on the 2 paths: - if groupId => verify(membershipManager).leaveGroup(); - else => verify(subscriptionState).unsubscribe(); -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org