Nancy-ksolves commented on PR #16438: URL: https://github.com/apache/kafka/pull/16438#issuecomment-2213529320
@showuon - Based on the discussion ([#16087 (comment)](https://github.com/apache/kafka/pull/16087#issuecomment-2163542758) ) regarding the metrics class changes. The metric objectName `kafka.log.remote:type=RemoteLogManager` is already in place. We have documented the addition of the following metrics for remote fetch throttling: remote-fetch-throttle-time-avg remote-fetch-throttle-time-max remote-copy-throttle-time-avg remote-copy-throttle-time-max The implementation in the metrics class covers `remote-fetch-throttle-time-avg` and `remote-fetch-throttle-time-max`. However, as per [KIP-956](https://cwiki.apache.org/confluence/display/KAFKA/KIP-956+Tiered+Storage+Quotas#KIP956TieredStorageQuotas-NewMetrics), we need to include all four metrics in the documentation. This JIRA ticket ([16887](https://issues.apache.org/jira/browse/KAFKA-16887)) is created to address the documentation for remote copy/fetch quotas metrics. If you want us to remove the additional 2 configs (remote-copy) then let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
