lianetm commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1668847329
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -312,31 +369,33 @@ public void testHeartbeatOutsideInterval() {
@Test
public void testNetworkTimeout() {
// The initial heartbeatInterval is set to 0
- resetWithZeroHeartbeatInterval(Optional.empty());
- mockStableMember();
+ time.sleep(DEFAULT_HEARTBEAT_INTERVAL_MS);
when(coordinatorRequestManager.coordinator()).thenReturn(Optional.of(new
Node(1, "localhost", 9999)));
+ when(heartbeatRequestState.canSendRequest(anyLong())).thenReturn(true);
NetworkClientDelegate.PollResult result =
heartbeatRequestManager.poll(time.milliseconds());
assertEquals(1, result.unsentRequests.size());
// Mimic network timeout
result.unsentRequests.get(0).handler().onFailure(time.milliseconds(),
new TimeoutException("timeout"));
+ time.sleep(1);
Review Comment:
not needed right? the flow we had (and should maintain) is:
1. poll generates HB and receives timeout as response
2. check backoff enforced (sleep backoff -1 , no request)
3. check new HB after backoff (sleep the 1ms that was missing to have the
full backoff and check HB generated).
Since we're mocking the membershipMgr now we should need to set expectations
to ensure that we're not skipping the hb because membershipMgr.shouldSkipHb is
true, and ensure that it's the backoff the one really kicking in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
