m1a2st commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1669472238


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##########
@@ -3665,6 +3670,18 @@ public void 
testWhenFetchResponseReturnsALeaderShipChangeErrorAndNewLeaderInform
         // Validate subscription is still valid & fetch-able for tp1.
         assertTrue(subscriptions.isFetchable(tp1));
     }
+    
+    @Test
+    public void testFetcherDontCacheAnyData() {
+        short version = 17;

Review Comment:
   @apoorvmittal10, Thanks for your comments, In `testFetchWithNoTopicId` have 
been test for version 12, Should I add a test only for 
`FetchResponse#responseData` this method to test version 12? WDYT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to