cmccabe commented on code in PR #16230:
URL: https://github.com/apache/kafka/pull/16230#discussion_r1672754939
##########
core/src/main/scala/kafka/server/MetadataCache.scala:
##########
@@ -121,7 +122,10 @@ object MetadataCache {
new ZkMetadataCache(brokerId, metadataVersion, brokerFeatures,
zkMigrationEnabled)
}
- def kRaftMetadataCache(brokerId: Int): KRaftMetadataCache = {
- new KRaftMetadataCache(brokerId)
+ def kRaftMetadataCache(
+ brokerId: Int,
+ kraftVersionSupplier: Supplier[KRaftVersion] = () =>
KRaftVersion.KRAFT_VERSION_0
Review Comment:
Yeah, default parameters are kind of icky. I'll remove the default parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
