chia7712 commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1673151480
##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -191,7 +191,7 @@ private KafkaConfig createNodeConfig(TestKitNode node) {
controllerNode.metadataDirectory());
}
props.put(SocketServerConfigs.LISTENER_SECURITY_PROTOCOL_MAP_CONFIG,
- "EXTERNAL:PLAINTEXT,CONTROLLER:PLAINTEXT");
+
"EXTERNAL:PLAINTEXT,CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT");
Review Comment:
Do we still need those changes?
##########
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##########
@@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(
ApiVersionsResponse.UNKNOWN_FINALIZED_FEATURES_EPOCH,
zkMigrationEnabled);
}
+
+ public static String getCurrentFunctionName() {
Review Comment:
IIRC, we had a discussion about the topic name. What is the updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
