chia7712 commented on code in PR #16019:
URL: https://github.com/apache/kafka/pull/16019#discussion_r1677223413
##########
tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java:
##########
@@ -239,4 +296,130 @@ public void shouldWorkWithoutTopicOption() throws
IOException {
verify(mockConsumer).subscribe(any(Pattern.class));
consumer.cleanup();
}
+
+ @ClusterTest(types = {Type.KRAFT, Type.CO_KRAFT}, brokers = 3)
+ public void testTransactionLogMessageFormatter() throws Exception {
+ try (Admin admin = cluster.createAdminClient()) {
+
+ List<TransactionLogTestcase> testcases = generateTestcases();
Review Comment:
This test does NOT include the scenario we do care.
1. we should verify the topic `__transaction_state` has data
2. we should verify the new formatter can parse the data of
`__transaction_state`
3. we can use arbitrary data in producing transaction since all we want to
check is the data in `__transaction_state`
##########
tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java:
##########
@@ -239,4 +296,130 @@ public void shouldWorkWithoutTopicOption() throws
IOException {
verify(mockConsumer).subscribe(any(Pattern.class));
consumer.cleanup();
}
+
+ @ClusterTest(types = {Type.KRAFT, Type.CO_KRAFT}, brokers = 3)
Review Comment:
we should check all types rather than only kraft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
