clolov commented on code in PR #16502:
URL: https://github.com/apache/kafka/pull/16502#discussion_r1679046863
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -752,8 +799,7 @@ private void maybeUpdateCopiedOffset(UnifiedLog log) throws
RemoteStorageExcepti
// previous leader epoch till it finds an entry, If there are
no entries till the earliest leader epoch in leader
// epoch cache then it starts copying the segments from the
earliest epoch entry's offset.
copiedOffsetOption =
Optional.of(findHighestRemoteOffset(topicIdPartition, log));
- logger.info("Found the highest copiedRemoteOffset: {} for
partition: {} after becoming leader, " +
- "leaderEpoch: {}", copiedOffsetOption,
topicIdPartition, leaderEpoch);
+ logger.info("Found the highest copiedRemoteOffset: {} for
partition: {} after becoming leader", copiedOffsetOption, topicIdPartition);
Review Comment:
I think we still need the reference to the leader epoch here given that this
is the leader, no? Or am I misunderstanding something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
