lianetm commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1681566194
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -580,39 +617,26 @@ public void testHeartbeatState() {
ConsumerGroupHeartbeatResponseData.Assignment assignmentTopic1 =
new ConsumerGroupHeartbeatResponseData.Assignment();
assignmentTopic1.setTopicPartitions(Collections.singletonList(tpTopic1));
- ConsumerGroupHeartbeatResponse rs1 = new
ConsumerGroupHeartbeatResponse(new ConsumerGroupHeartbeatResponseData()
+ rs1 = new ConsumerGroupHeartbeatResponse(new
ConsumerGroupHeartbeatResponseData()
.setHeartbeatIntervalMs(DEFAULT_HEARTBEAT_INTERVAL_MS)
- .setMemberId(memberId)
+ .setMemberId(DEFAULT_MEMBER_ID)
.setMemberEpoch(1)
.setAssignment(assignmentTopic1));
when(metadata.topicNames()).thenReturn(Collections.singletonMap(topicId,
"topic1"));
- membershipManager.onHeartbeatSuccess(rs1.data());
+ mockReconcilingState();
// We remain in RECONCILING state, as the assignment will be
reconciled on the next poll
assertEquals(MemberState.RECONCILING, membershipManager.state());
Review Comment:
ditto (and the `mockReconcilingState` could be completely removed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
