lianetm commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1683379819
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ########## @@ -898,6 +837,30 @@ private HeartbeatRequestManager createHeartbeatRequestManager( heartbeatState, heartbeatRequestState, backgroundEventHandler, - metrics); + new Metrics()); + } + + private void mockJoiningMemberData(String instanceId) { + when(membershipManager.groupInstanceId()).thenReturn(Optional.ofNullable(instanceId)); + when(membershipManager.memberId()).thenReturn(""); + when(membershipManager.memberEpoch()).thenReturn(0); + when(membershipManager.groupId()).thenReturn(DEFAULT_GROUP_ID); + when(membershipManager.currentAssignment()).thenReturn(LocalAssignment.NONE); + when(membershipManager.serverAssignor()).thenReturn(Optional.of(DEFAULT_REMOTE_ASSIGNOR)); + } + + private void mockFencedToJoiningMemberData() { + when(membershipManager.state()).thenReturn(MemberState.JOINING); + when(membershipManager.memberEpoch()).thenReturn(0); + when(membershipManager.groupInstanceId()).thenReturn(Optional.empty()); + } + + private void mockDefaultMemberData(String instanceId) { Review Comment: nit: `mockStableMemberData` maybe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org