jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1684693402
########## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ########## @@ -381,10 +381,12 @@ class BrokerLifecycleManager( private def sendBrokerRegistration(): Unit = { val features = new BrokerRegistrationRequestData.FeatureCollection() _supportedFeatures.asScala.foreach { - case (name, range) => features.add(new BrokerRegistrationRequestData.Feature(). + // Do not include features with the range 0-0. + case (name, range) if range.max() > 0 => features.add(new BrokerRegistrationRequestData.Feature(). Review Comment: Yeah. It is already excluded from Colin's commit. If we want to share the logic we can move it to Broker/QuorumFeatures, but I wasn't sure if there was a reason why Colin did it in the response before. cc: @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org