ahuang98 commented on code in PR #16637:
URL: https://github.com/apache/kafka/pull/16637#discussion_r1687038111
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse(
long highWatermark,
List<ReplicaState> voterStates,
List<ReplicaState> observerStates
+ ) {
+ short apiVersion = (short) (kip853Rpc ? 2 : 1);
Review Comment:
Yep, those take care of supplying the latest versions supported for
describeQuorum. I wanted to add functionality to create older versions of
describeQuorumResponse - in order to do that I needed to add an apiVersions
param to one of these overloaded helpers and alter this one to pass in the
apiVersion explicitly (which duplicates what describeQuorumRpcVersion() does).
I'll at least use describeQuorumRpcVersion() here instead of duplicating the
code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
