ahuang98 commented on code in PR #16637:
URL: https://github.com/apache/kafka/pull/16637#discussion_r1689134569
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse(
long highWatermark,
List<ReplicaState> voterStates,
List<ReplicaState> observerStates
+ ) {
+ short apiVersion = (short) (kip853Rpc ? 2 : 1);
+ assertSentDescribeQuorumResponse(leaderId, leaderEpoch, highWatermark,
voterStates, observerStates, apiVersion, Errors.NONE);
+ }
+
+ void assertSentDescribeQuorumResponse(
+ int leaderId,
+ int leaderEpoch,
+ long highWatermark,
+ List<ReplicaState> voterStates,
+ List<ReplicaState> observerStates,
+ short apiVersion,
Review Comment:
discussed offline, `withKip853Rpc` currently indicates more than what RPC
versions the test should use (for instance if non-zero directory ids should be
used in the tests), but I've convinced myself why that works.
I'm removing `testDescribeQuorumOld` and will have the equiv functionality
covered in `testDescribeQuorumWithFollowers(boolean withKip853Rpc=false)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
