[ 
https://issues.apache.org/jira/browse/KAFKA-17137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated KAFKA-17137:
-----------------------------------
    Description: 
A number of Admin client APIs don't have integration tests. While testing 3.8.0 
RC0 we discovered the Admin.describeTopics() API hung. This should have been 
caught by tests.

I suggest to create subtasks for each API that needs tests.

*Part 0*

[https://github.com/apache/kafka/pull/16676]

createTopics + retryOnQuotaViolation
deleteTopics + timeoutMs
deleteTopics + retryOnQuotaViolation
listTopics + timeoutMs
listTopics + listInternal
describeTopics + timeoutMs
describeTopics + partitionSizeLimitPerResponse

*Part 1*
[https://github.com/apache/kafka/pull/16648]
describeAcls + timeoutMs
createAcls + timeoutMs
deleteAcls + timeoutMs
describeConfigs + timeoutMs
alterConfigs + timeoutMs
expireDelegationToken + expiryTimePeriodMs
[https://github.com/apache/kafka/pull/16687]
createPartitions + retryOnQuotaViolation


*Part 2*
[https://github.com/apache/kafka/pull/16717]
listConsumerGroups + withTypes
listConsumerGroupOffsets(groupId) + requireStable
listConsumerGroupOffsets(groupSpecs) + requireStable
listConsumerGroupOffsets(groupSpecs)
removeMembersFromConsumerGroup + reason
alterConsumerGroupOffsets
alterClientQuotas + validateOnly

*Part 3*
[https://github.com/apache/kafka/pull/16652] (done)
describeUserScramCredentials
describeProducers + brokerId
describeTransactions + timeoutMs
abortTransaction + timeoutMs
listTransactions + filterStates
listTransactions + filterProducerIds
listTransactions + filterOnDuration

*Part 4*
[https://github.com/apache/kafka/pull/16658]
fenceProducers + timeoutMs
listClientMetricsResources
listClientMetricsResources + timeoutMs
clientInstanceId
addRaftVoter
removeRaftVoter
metrics

*part 5*
createDelegationToken + maxLifeTimeStamp + 
DELEGATION_TOKEN_EXPIRY_TIME_MS_CONFIG

  was:
A number of Admin client APIs don't have integration tests. While testing 3.8.0 
RC0 we discovered the Admin.describeTopics() API hung. This should have been 
caught by tests.

I suggest to create subtasks for each API that needs tests.

*Part 0*

[https://github.com/apache/kafka/pull/16676]

createTopics + retryOnQuotaViolation
deleteTopics + timeoutMs
deleteTopics + retryOnQuotaViolation
listTopics + timeoutMs
listTopics + listInternal
describeTopics + timeoutMs
describeTopics + partitionSizeLimitPerResponse

*Part 1*
[https://github.com/apache/kafka/pull/16648]
describeAcls + timeoutMs
createAcls + timeoutMs
deleteAcls + timeoutMs
describeConfigs + timeoutMs
alterConfigs + timeoutMs
expireDelegationToken + expiryTimePeriodMs
[https://github.com/apache/kafka/pull/16687]
createPartitions + retryOnQuotaViolation


*Part 2*
[https://github.com/apache/kafka/pull/16717]
listConsumerGroups + withTypes
listConsumerGroupOffsets(groupId) + requireStable
listConsumerGroupOffsets(groupSpecs) + requireStable
listConsumerGroupOffsets(groupSpecs)
removeMembersFromConsumerGroup + reason
alterConsumerGroupOffsets
alterClientQuotas + validateOnly

*Part 3*
[https://github.com/apache/kafka/pull/16652] (done)
describeUserScramCredentials
describeProducers + brokerId
describeTransactions + timeoutMs
abortTransaction + timeoutMs
listTransactions + filterStates
listTransactions + filterProducerIds
listTransactions + filterOnDuration

*Part 4*
[https://github.com/apache/kafka/pull/16658]
fenceProducers + timeoutMs
listClientMetricsResources
listClientMetricsResources + timeoutMs
clientInstanceId
addRaftVoter
removeRaftVoter
metrics


> Ensure Admin APIs are properly tested
> -------------------------------------
>
>                 Key: KAFKA-17137
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17137
>             Project: Kafka
>          Issue Type: Improvement
>          Components: admin
>            Reporter: Mickael Maison
>            Assignee: Chia-Ping Tsai
>            Priority: Major
>
> A number of Admin client APIs don't have integration tests. While testing 
> 3.8.0 RC0 we discovered the Admin.describeTopics() API hung. This should have 
> been caught by tests.
> I suggest to create subtasks for each API that needs tests.
> *Part 0*
> [https://github.com/apache/kafka/pull/16676]
> createTopics + retryOnQuotaViolation
> deleteTopics + timeoutMs
> deleteTopics + retryOnQuotaViolation
> listTopics + timeoutMs
> listTopics + listInternal
> describeTopics + timeoutMs
> describeTopics + partitionSizeLimitPerResponse
> *Part 1*
> [https://github.com/apache/kafka/pull/16648]
> describeAcls + timeoutMs
> createAcls + timeoutMs
> deleteAcls + timeoutMs
> describeConfigs + timeoutMs
> alterConfigs + timeoutMs
> expireDelegationToken + expiryTimePeriodMs
> [https://github.com/apache/kafka/pull/16687]
> createPartitions + retryOnQuotaViolation
> *Part 2*
> [https://github.com/apache/kafka/pull/16717]
> listConsumerGroups + withTypes
> listConsumerGroupOffsets(groupId) + requireStable
> listConsumerGroupOffsets(groupSpecs) + requireStable
> listConsumerGroupOffsets(groupSpecs)
> removeMembersFromConsumerGroup + reason
> alterConsumerGroupOffsets
> alterClientQuotas + validateOnly
> *Part 3*
> [https://github.com/apache/kafka/pull/16652] (done)
> describeUserScramCredentials
> describeProducers + brokerId
> describeTransactions + timeoutMs
> abortTransaction + timeoutMs
> listTransactions + filterStates
> listTransactions + filterProducerIds
> listTransactions + filterOnDuration
> *Part 4*
> [https://github.com/apache/kafka/pull/16658]
> fenceProducers + timeoutMs
> listClientMetricsResources
> listClientMetricsResources + timeoutMs
> clientInstanceId
> addRaftVoter
> removeRaftVoter
> metrics
> *part 5*
> createDelegationToken + maxLifeTimeStamp + 
> DELEGATION_TOKEN_EXPIRY_TIME_MS_CONFIG



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to