[ 
https://issues.apache.org/jira/browse/KAFKA-16818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873053#comment-17873053
 ] 

Kirk True commented on KAFKA-16818:
-----------------------------------

Yes. Those tests are all basically testing that the 
{{ApplicationEventProcessor}} invokes the correct {{process()}} method given 
the input, so they make more sense in the {{ApplicationEventProcessorTest}} 
class.

> Move event processing-related tests from ConsumerNetworkThreadTest to 
> ApplicationEventProcessorTest
> ---------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-16818
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16818
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients, consumer, unit tests
>    Affects Versions: 3.8.0
>            Reporter: Kirk True
>            Priority: Minor
>              Labels: consumer-threading-refactor
>             Fix For: 4.0.0
>
>
> The {{ConsumerNetworkThreadTest}} currently has a number of tests which do 
> the following:
>  # Add event of type _T_ to the event queue
>  # Call {{ConsumerNetworkThread.runOnce()}} to dequeue the events and call 
> {{ApplicationEventProcessor.process()}}
>  # Verify that the appropriate {{ApplicationEventProcessor}} process method 
> was invoked for the event
> Those types of tests should be moved to {{{}ApplicationEventProcessorTest{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to