[ 
https://issues.apache.org/jira/browse/KAFKA-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876108#comment-17876108
 ] 

Lianet Magrans commented on KAFKA-17377:
----------------------------------------

I was involved in the PR where this came out to align with what's done 
elsewhere in the consumer, whenever we need to time box an operation without a 
provided timeout, makes total thanks to me. Please reach out to us to help with 
questions/reviews [~yangpoan], thanks! 

> Consider using defaultApiTimeoutMs in AsyncKafkaConsumer#unsubscribe
> --------------------------------------------------------------------
>
>                 Key: KAFKA-17377
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17377
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients, consumer
>            Reporter: PoAn Yang
>            Assignee: PoAn Yang
>            Priority: Major
>              Labels: consumer-threading-refactor
>
> This is followup from 
> [https://github.com/apache/kafka/pull/16673#discussion_r1717009724]
> AsyncKafkaConsumer#unsubscribe uses Long.MAX_VALUE to calculate deadline. 
> However, most of AsyncKafkaConsumer operations use 
> [default.api.timeout.ms|https://kafka.apache.org/documentation/#consumerconfigs_default.api.timeout.ms]
>  if users don't specify a timeout. In [design 
> document|https://cwiki.apache.org/confluence/display/KAFKA/Java+client+Consumer+timeouts#JavaclientConsumertimeouts-DefaultTimeouts],
>  it also mentions that using default.api.timeout.ms as default timeout.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to