jolshan commented on code in PR #16973:
URL: https://github.com/apache/kafka/pull/16973#discussion_r1733212040
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -153,50 +186,92 @@ object StorageTool extends Logging {
}
def parseArguments(args: Array[String]): Namespace = {
- val parser = ArgumentParsers.
- newArgumentParser("kafka-storage", /* defaultHelp */ true, /*
prefixChars */ "-", /* fromFilePrefix */ "@").
- description("The Kafka storage tool.")
+ val parser = ArgumentParsers
+ .newArgumentParser("kafka-storage", true, "-", "@")
+ .description("The Kafka storage tool.")
val subparsers = parser.addSubparsers().dest("command")
- val infoParser = subparsers.addParser("info").
- help("Get information about the Kafka log directories on this node.")
- val formatParser = subparsers.addParser("format").
- help("Format the Kafka log directories on this node.")
- subparsers.addParser("random-uuid").help("Print a random UUID.")
- List(infoParser, formatParser).foreach(parser => {
Review Comment:
Maybe not a huge deal, but I believe we reordered the parsers for
formatParser. I think we can just call the commonArguments/Config parser method
first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
