smjn commented on code in PR #17011:
URL: https://github.com/apache/kafka/pull/17011#discussion_r1733267229


##########
core/src/main/java/kafka/server/builders/KafkaApisBuilder.java:
##########
@@ -195,6 +202,7 @@ public KafkaApis build() {
                              replicaManager,
                              groupCoordinator,
                              txnCoordinator,
+                             shareCoordinator,

Review Comment:
   share coordinator can be null - there is a specific flag on basis of which 
share coord is initialized in BrokerServer, otw it is null. I can do a Optional 
perhaps



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to