unknowntpo commented on code in PR #16648:
URL: https://github.com/apache/kafka/pull/16648#discussion_r1733726177
##########
clients/src/main/java/org/apache/kafka/clients/admin/ExpireDelegationTokenOptions.java:
##########
@@ -28,7 +28,14 @@
public class ExpireDelegationTokenOptions extends
AbstractOptions<ExpireDelegationTokenOptions> {
private long expiryTimePeriodMs = -1L;
- public ExpireDelegationTokenOptions expiryTimePeriodMs(long
expiryTimePeriodMs) {
+ /**
+ * @param expiryTimePeriodMs the time period until we should expire this
token.
+ * {@code expiryTimePeriodMs} >= 0: the token will update the expiration
timestamp to min(now + expiryTimePeriodMs, maxTimestamp)
Review Comment:
fixed.
##########
clients/src/main/java/org/apache/kafka/clients/admin/ExpireDelegationTokenOptions.java:
##########
@@ -28,7 +28,14 @@
public class ExpireDelegationTokenOptions extends
AbstractOptions<ExpireDelegationTokenOptions> {
private long expiryTimePeriodMs = -1L;
- public ExpireDelegationTokenOptions expiryTimePeriodMs(long
expiryTimePeriodMs) {
+ /**
+ * @param expiryTimePeriodMs the time period until we should expire this
token.
+ * {@code expiryTimePeriodMs} >= 0: the token will update the expiration
timestamp to min(now + expiryTimePeriodMs, maxTimestamp)
+ * {@code expiryTimePeriodMs} < 0: token will be expired immediately.
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
