showuon commented on code in PR #16866: URL: https://github.com/apache/kafka/pull/16866#discussion_r1733912976
########## core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala: ########## @@ -97,6 +98,15 @@ class UncleanLeaderElectionTest extends QuorumTestHarness { super.tearDown() } + override def kraftControllerConfigs(testInfo: TestInfo): Seq[Properties] = { + val properties = new Properties() + if (testInfo.getTestMethod.get().getName.contains("testUncleanLeaderElectionEnabled")) { + properties.setProperty("unclean.leader.election.enable", "true") + } + properties.setProperty("leader.imbalance.check.interval.seconds", "1") Review Comment: The `testTopicUncleanLeaderElectionEnableWithAlterTopicConfigs` is failing because we need to use the `unclean.leader.election.interval.ms` config now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org