[ 
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878191#comment-17878191
 ] 

Lianet Magrans commented on KAFKA-16792:
----------------------------------------

Thinking more about this, I wonder if we could make things slightly better and 
more consistent with the classic consumer, if we ensure that consumer.poll 
allows for at least one run of the background thread before returning? With 
that we would guarantee that poll(lowTimeout) generates the requests it needs 
(just like the classic consumer does), even though it may not have the time to 
wait for them. Note that this would instantly align the bevahiour in tests like 
testFetchStableOffsetThrowInPoll I guess, see my comment 
[there|https://github.com/apache/kafka/pull/16982/files#r1739141821] . Maybe a 
PollEvent that would do nothing in the background other than complete, but 
would serve as a signal to the foreground indicating that there're been 1 full 
cycle in the background. (just rough ideas for now, this requires more 
thinking, thoughts?)

> Enable consumer unit tests that fail to fetch offsets only for new consumer 
> with poll(0)
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-16792
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16792
>             Project: Kafka
>          Issue Type: Test
>          Components: clients, consumer, unit tests
>            Reporter: Lianet Magrans
>            Assignee: PoAn Yang
>            Priority: Blocker
>              Labels: kip-848-client-support
>             Fix For: 4.0.0
>
>
> Enable the following unit tests for the new async consumer in 
> KafkaConsumerTest:
>  - testCurrentLag
>  - testFetchStableOffsetThrowInPoll
>  - testListOffsetShouldUpdateSubscriptions
>  - testPollReturnsRecords
>  - testResetToCommittedOffset
>  - testResetUsingAutoResetPolicy
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to