[
https://issues.apache.org/jira/browse/KAFKA-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632572#comment-16632572
]
ASF GitHub Bot commented on KAFKA-6620:
---------------------------------------
guozhangwang closed pull request #5434: KAFKA-6620: Documentation about
'exactly_once' doesn't mention 'transaction.state.log.min.isr'
URL: https://github.com/apache/kafka/pull/5434
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/streams/developer-guide/config-streams.html
b/docs/streams/developer-guide/config-streams.html
index 75f1045de14..a2265178759 100644
--- a/docs/streams/developer-guide/config-streams.html
+++ b/docs/streams/developer-guide/config-streams.html
@@ -452,7 +452,7 @@ <h4><a class="toc-backref"
href="#id11">num.stream.threads</a><a class="headerli
and producers are configured with <code class="docutils
literal"><span class="pre">retries=Integer.MAX_VALUE</span></code>, <code
class="docutils literal"><span
class="pre">enable.idempotence=true</span></code>,
and <code class="docutils literal"><span
class="pre">max.in.flight.requests.per.connection=1</span></code> per default.
Note that by default exactly-once processing requires a
cluster of at least three brokers what is the recommended setting for
production.
- For development you can change this, by adjusting broker
setting <code class="docutils literal"><span
class="pre">transaction.state.log.replication.factor</span></code> to the
number of broker you want to use.
+ For development you can change this, by adjusting broker
setting <code class="docutils literal"><span
class="pre">transaction.state.log.replication.factor</span></code> and <code
class="docutils literal"><span
class="pre">transaction.state.log.min.isr</span></code> to the number of broker
you want to use.
For more details see <a
href="../core-concepts#streams_processing_guarantee">Processing Guarantees</a>.
</div></blockquote>
</div>
diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index b9eaaa68f67..06aea215624 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -391,7 +391,8 @@
@SuppressWarnings("WeakerAccess")
public static final String PROCESSING_GUARANTEE_CONFIG =
"processing.guarantee";
private static final String PROCESSING_GUARANTEE_DOC = "The processing
guarantee that should be used. Possible values are <code>" + AT_LEAST_ONCE +
"</code> (default) and <code>" + EXACTLY_ONCE + "</code>. " +
- "Note that exactly-once processing requires a cluster of at least
three brokers by default what is the recommended setting for production; for
development you can change this, by adjusting broker setting
<code>transaction.state.log.replication.factor</code>.";
+ "Note that exactly-once processing requires a cluster of at least
three brokers by default what is the recommended setting for production; for
development you can change this, by adjusting broker setting " +
+ "<code>transaction.state.log.replication.factor</code> and
<code>transaction.state.log.min.isr</code>.";
/** {@code receive.buffer.bytes} */
@SuppressWarnings("WeakerAccess")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Documentation about "exactly_once" doesn't mention
> "transaction.state.log.min.isr"
> -----------------------------------------------------------------------------------
>
> Key: KAFKA-6620
> URL: https://issues.apache.org/jira/browse/KAFKA-6620
> Project: Kafka
> Issue Type: Bug
> Components: documentation, streams
> Reporter: Daniel Qian
> Priority: Major
>
> Documentation about "processing.guarantee" says:
> {quote}The processing guarantee that should be used. Possible values are
> {{at_least_once}}(default) and {{exactly_once}}. Note that exactly-once
> processing requires a cluster of at least three brokers by default what is
> the recommended setting for production; *for development you can change this,
> by adjusting broker setting*
> `{color:#FF0000}*transaction.state.log.replication.factor*{color}`
> {quote}
> If one only set *transaction.state.log.replication.factor=1* but leave
> *transaction.state.log.min.isr* with default value (which is 2) the Streams
> Application will break.
> Hope you guys modify the doc, thanks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
