soarez commented on PR #17004:
URL: https://github.com/apache/kafka/pull/17004#issuecomment-2332794244

   @mumrah makes sense. Seems that was maybe an unlucky run anyway, as only one 
execution was skipped in the latest run:
   
   
   ```
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [1] Type=ZK, 
MetadataVersion=3.5-IV2,Security=PLAINTEXT       11 sec  Passed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [1] Type=ZK, 
MetadataVersion=3.5-IV2,Security=PLAINTEXT       16 sec  Passed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [1] Type=ZK, 
MetadataVersion=3.5-IV2,Security=PLAINTEXT        9.1 sec Passed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [2] Type=ZK, 
MetadataVersion=3.6-IV2,Security=PLAINTEXT       5 min 20 sec    Failed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [2] Type=ZK, 
MetadataVersion=3.6-IV2,Security=PLAINTEXT       5 min 19 sec    Failed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [2] Type=ZK, 
MetadataVersion=3.6-IV2,Security=PLAINTEXT        9.5 sec Fixed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [3] Type=ZK, 
MetadataVersion=3.7-IV0,Security=PLAINTEXT        11 sec  Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [3] Type=ZK, 
MetadataVersion=3.7-IV0,Security=PLAINTEXT       5 min 22 sec    Failed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [3] Type=ZK, 
MetadataVersion=3.7-IV0,Security=PLAINTEXT       5 min 19 sec    Failed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [4] Type=ZK, 
MetadataVersion=3.7-IV1,Security=PLAINTEXT       5 min 20 sec    Failed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [4] Type=ZK, 
MetadataVersion=3.7-IV1,Security=PLAINTEXT        11 sec  Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [4] Type=ZK, 
MetadataVersion=3.7-IV1,Security=PLAINTEXT       12 sec  Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [5] Type=ZK, 
MetadataVersion=3.7-IV2,Security=PLAINTEXT       14 sec  Fixed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [5] Type=ZK, 
MetadataVersion=3.7-IV2,Security=PLAINTEXT        8.7 sec Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [5] Type=ZK, 
MetadataVersion=3.7-IV2,Security=PLAINTEXT       10 sec  Fixed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [6] Type=ZK, 
MetadataVersion=3.7-IV4,Security=PLAINTEXT        8.7 sec Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [6] Type=ZK, 
MetadataVersion=3.7-IV4,Security=PLAINTEXT       11 sec  Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [6] Type=ZK, 
MetadataVersion=3.7-IV4,Security=PLAINTEXT       9.6 sec Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [7] Type=ZK, 
MetadataVersion=3.8-IV0,Security=PLAINTEXT       5 min 19 sec    Failed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [7] Type=ZK, 
MetadataVersion=3.8-IV0,Security=PLAINTEXT        8.8 sec Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [7] Type=ZK, 
MetadataVersion=3.8-IV0,Security=PLAINTEXT       10 sec  Fixed
   Build / JDK 8 and Scala 2.12 / testMigrateTopicDeletions [8] Type=ZK, 
MetadataVersion=3.9-IV0,Security=PLAINTEXT        9.6 sec Fixed
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [8] Type=ZK, 
MetadataVersion=3.9-IV0,Security=PLAINTEXT       16 sec  Skipped
   Build / JDK 21 and Scala 2.13 / testMigrateTopicDeletions [8] Type=ZK, 
MetadataVersion=3.9-IV0,Security=PLAINTEXT       17 sec  Fixed
   ```
   
   
   However, there are 6 failures, all hitting the same 5 minute timeout to 
delete topics:
   
   ```
   org.opentest4j.AssertionFailedError: Timed out waiting for topics to be 
deleted
        at 
app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
        at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:138)
        at 
app//kafka.zk.ZkMigrationIntegrationTest.testMigrateTopicDeletions(ZkMigrationIntegrationTest.scala:386)
   ```
   
   Does this mean there's some race condition wherein after the migration the 
topics cannot be deleted? I'm wondering if the test should timeout earlier and 
retry the deletion. If the topics cannot be deleted at all after the migration, 
that would be a serious bug.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to