mimaison commented on code in PR #17134: URL: https://github.com/apache/kafka/pull/17134#discussion_r1750579322
########## server/src/main/java/org/apache/kafka/network/metrics/RequestMetrics.java: ########## @@ -214,5 +215,20 @@ private DeprecatedRequestRateKey(short version, ClientInformation clientInformat this.version = version; this.clientInformation = clientInformation; } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + DeprecatedRequestRateKey that = (DeprecatedRequestRateKey) o; + return version == that.version && Objects.equals(clientInformation, that.clientInformation); + } + + @Override + public int hashCode() { + int result = version; Review Comment: Sure, done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org