apoorvmittal10 commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1757064893


##########
share-coordinator/src/test/java/org/apache/kafka/coordinator/share/ShareCoordinatorShardTest.java:
##########
@@ -791,6 +793,304 @@ public void testNonSequentialBatchUpdates() {
         verify(shard.getMetricsShard(), 
times(3)).record(ShareCoordinatorMetrics.SHARE_COORDINATOR_WRITE_SENSOR_NAME);
     }
 
+    @Test
+    public void testStateBatchCombine() {

Review Comment:
   But parametrization will not fail specific scenario which is often easy to 
debug and fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to