apoorvmittal10 commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1775445081
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -547,6 +551,8 @@ static KafkaAdminClient createInternal(
MetricsContext metricsContext = new KafkaMetricsContext(JMX_PREFIX,
config.originalsWithPrefix(CommonClientConfigs.METRICS_CONTEXT_PREFIX));
metrics = new Metrics(metricConfig, reporters, time,
metricsContext);
+ clientTelemetryReporter =
CommonClientConfigs.telemetryReporter(clientId, config);
+ clientTelemetryReporter.ifPresent(telemetryReporter ->
telemetryReporter.contextChange(metricsContext));
Review Comment:
So the only metric I think admin client emits is `node latency` metric,
which also got recently added as regression. Though I understand that KS wants
to send application metrics as part of admin client but we will be adding an
additional overhead with short lived admin client operations. I am not very
aligned regarding with KIP-714 integration in admin client. @AndrewJSchofield
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
