viktorsomogyi commented on code in PR #17413:
URL: https://github.com/apache/kafka/pull/17413#discussion_r1792068739
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -105,6 +105,7 @@ public class MirrorSourceConnector extends SourceConnector {
private int replicationFactor;
private Admin sourceAdminClient;
private Admin targetAdminClient;
+ private boolean heartbeatsReplicationEnabled = true;
Review Comment:
Well, I see your point but it seems like the test constructors are quite
inconsistent in this and they pick and choose in what they initialize. I ran
all tests in `org.apache.kafka.connect.mirror` without setting this and they
seemed to work so I'm not sure if there are any effects on existing tests.
It would be nice to have a constructor "chain" that gives everything some
default values but that would be a different work.
I would prefer if we kept the convention of initializing in the
constructor/start() when needed but if you insist on this, then please use the
constant`HEARTBEATS_REPLICATION_ENABLED_DEFAULT` in `MirrorSourceConfig` to
avoid hardcoding values, that would be a compromise I could live with :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
