lucasbru commented on code in PR #17391:
URL: https://github.com/apache/kafka/pull/17391#discussion_r1792098745
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupInitializeRequestManager.java:
##########
@@ -95,18 +100,65 @@ private static
StreamsGroupInitializeRequestData.Subtopology getSubtopologyFromS
final StreamsGroupInitializeRequestData.Subtopology subtopologyData =
new StreamsGroupInitializeRequestData.Subtopology();
subtopologyData.setSubtopologyId(subtopologyName);
subtopologyData.setSourceTopics(new
ArrayList<>(subtopology.sourceTopics));
+ Collections.sort(subtopologyData.sourceTopics());
Review Comment:
Yes. We want to make the topology deterministic, otherwise we'll get
reinitializations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
