jolshan commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1792228914
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -348,7 +348,10 @@ private TransactionalRequestResult
beginCompletingTransaction(TransactionResult
.setTransactionalId(transactionalId)
.setProducerId(producerIdAndEpoch.producerId)
.setProducerEpoch(producerIdAndEpoch.epoch)
- .setCommitted(transactionResult.id));
+ .setCommitted(transactionResult.id),
+ true,
Review Comment:
I think in this PR we can mark EndTxn stable so this value doesn't need to
be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
