frankvicky commented on code in PR #17456:
URL: https://github.com/apache/kafka/pull/17456#discussion_r1795725213
##########
clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java:
##########
@@ -155,22 +155,6 @@ public void testToListOffsetsTopics() {
assertTrue(topic.partitions().contains(lop1));
}
- @Test
- public void testCheckEarliestLocalTimestampVersion() {
- int maxVersion = ApiKeys.LIST_OFFSETS.latestVersion();
- for (int i = 0; i <= maxVersion; i++) {
- testUnsupportedVersion(i, EARLIEST_LOCAL_TIMESTAMP);
- }
- }
-
- @Test
- public void testCheckLatestTieredTimestampVersion() {
- int maxVersion = ApiKeys.LIST_OFFSETS.latestVersion();
- for (int i = 0; i <= maxVersion; i++) {
- testUnsupportedVersion(i, LATEST_TIERED_TIMESTAMP);
- }
- }
-
private void testUnsupportedVersion(int version, long timestamp) {
Review Comment:
This helper method is unused after removing the tests. Please remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
