mumrah commented on code in PR #17397:
URL: https://github.com/apache/kafka/pull/17397#discussion_r1797000223
##########
build.gradle:
##########
@@ -212,7 +212,22 @@ def determineCommitId() {
}
}
-
+/**
+ * For a given Project, compute a nice dash separated directory name
+ * to store the JUnit XML files in. E.g., Project ":connect:api" ->
"connect-api"
Review Comment:
I considered this, but didn't want to add special cases to the "module name
finding" method.
The module name computed here (e.g., `connect-api`, `clients`,
`group-coordinator-group-coordinator-api`) will determine the name of the
directory in build/junit-xml. As long as its unique, it doesn't matter too much
what it is.
Another option here would be to reflect the actual module _paths_ in the
output directory paths. So, `:connect:api` test results would end up in
"build/junit-xml/connect/api/[test, quarantinedTest]/...". This also cause the
test catalog directories to mirror the actual layout of the project.
##########
build.gradle:
##########
@@ -212,7 +212,22 @@ def determineCommitId() {
}
}
-
+/**
+ * For a given Project, compute a nice dash separated directory name
+ * to store the JUnit XML files in. E.g., Project ":connect:api" ->
"connect-api"
Review Comment:
I considered this, but didn't want to add special cases to the "module name
finding" method.
The module name computed here (e.g., `connect-api`, `clients`,
`group-coordinator-group-coordinator-api`) will determine the name of the
directory in build/junit-xml. As long as its unique, it doesn't matter too much
what it is.
Another option here would be to reflect the actual module _paths_ in the
output directory paths. So, `:connect:api` test results would end up in
"build/junit-xml/connect/api/[test, quarantinedTest]/...". This would also
cause the test catalog directories to mirror the actual layout of the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
