[
https://issues.apache.org/jira/browse/KAFKA-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640272#comment-16640272
]
ASF GitHub Bot commented on KAFKA-6914:
---------------------------------------
hachikuji closed pull request #5720: KAFKA-6914: Set parent classloader of
DelegatingClassLoader same as the worker's
URL: https://github.com/apache/kafka/pull/5720
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
index 144dbd87f55..6104dd4426a 100644
---
a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
+++
b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
@@ -94,7 +94,11 @@ public DelegatingClassLoader(List<String> pluginPaths,
ClassLoader parent) {
}
public DelegatingClassLoader(List<String> pluginPaths) {
- this(pluginPaths, ClassLoader.getSystemClassLoader());
+ // Use as parent the classloader that loaded this class. In most cases
this will be the
+ // System classloader. But this choice here provides additional
flexibility in managed
+ // environments that control classloading differently (OSGi, Spring
and others) and don't
+ // depend on the System classloader to load Connect's classes.
+ this(pluginPaths, DelegatingClassLoader.class.getClassLoader());
}
public Set<PluginDesc<Connector>> connectors() {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Kafka Connect - Plugins class should have a constructor that can take in
> parent ClassLoader
> -------------------------------------------------------------------------------------------
>
> Key: KAFKA-6914
> URL: https://issues.apache.org/jira/browse/KAFKA-6914
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Reporter: Sriram KS
> Assignee: Konstantine Karantasis
> Priority: Minor
>
> Currently Plugins class has a single constructor that takes in map of props.
> Please make Plugin class to have a constructor that takes in a classLoader as
> well and use it to set DelegationClassLoader's parent classLoader.
> Reason:
> This will be useful if i am already having a managed class Loader environment
> like a Spring boot app which resolves my class dependencies using my
> maven/gradle dependency management.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
