lianetm commented on PR #17411: URL: https://github.com/apache/kafka/pull/17411#issuecomment-2407977107
Hey folks, aligned with @dajac 's comment on the approach, I think we should keep the solution scoped to the client and the HB RPC specifically (which is what will fail in this scenario we're after of client on the new protocol + broker that doesn't support it). We already handle this on the client side on the HeartbeatRequestManager: https://github.com/apache/kafka/blob/e864d8f168c884624c2d0a88ecbe280bd045d864/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java#L381-L384 So what about we just change to a better error message there (the one suggested above sounds good to me). With that, the moment a client sends a first HB we'll generate the improved error message (member transitions to fatal and the error is propagated to the app thread and to the user on poll, all this is in place already) Makes sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
